google / truth

Fluent assertions for Java and Android
https://truth.dev/
Apache License 2.0
2.73k stars 260 forks source link

Link to Java 21 Javadoc instead of Java 7. #1359

Closed copybara-service[bot] closed 2 weeks ago

copybara-service[bot] commented 2 weeks ago

Link to Java 21 Javadoc instead of Java 7.

I had hoped that maybe this would help with the error that I saw when building with the Javadoc from JDK 21:

[ERROR] error: Unexpected redirection for URL https://docs.oracle.com/javase/7/docs/api/element-list to https://docs.oracle.com/javase/7/docs/api/

It turns out not to help with that.

However, the change does lead us to produce actual links to JDK types in e.g., http://truth.dev/StringSubject. (This sounds like it's different from what I previously saw in Guava, where generating Javadoc with JDK 21 (while not updating the version we link to) also fixed links. I guess I should consider updating Guava to link to Java 21, too.)

Our old behavior of linking to Java 7 arguably made some sense when that was the minimum version that we supported. But we've required Java 8 for a while now. And really, some even newer version seems likely to be useful to most users, who have largely upgraded. And given that Google search is already not great at finding Javadoc at all (let alone new versions), maybe it's good for us to get into the practice of linking to newer versions to see if that helps improve their rankings??

RELNOTES=n/a