Refactor fit() and predict()

google / uis-rnn

This is the library for the Unbounded Interleaved-State Recurrent Neural Network (UIS-RNN) algorithm, corresponding to the paper Fully Supervised Speaker Diarization.

https://arxiv.org/abs/1810.04719

Apache License 2.0

1.55k stars 320 forks source link

Refactor fit() and predict() #7

Closed wq2012 closed 5 years ago

wq2012 commented 5 years ago

Current fit() and predict() functions are too long.

We should refactor them to move some components out and make them more readable.

LoveGalaxy commented 5 years ago

How will it finish? I can not understand the two functions. Could I ask some questions about the two functions in this Issue?

wq2012 commented 5 years ago

We are currently working on this. Please be patient.

Yes, the two functions are not very readable now, especially the predict() function. We will rewrite with a more object-oriented approach with detailed comments.