Use same flag names for equivalent inputs in `eval_proc_main` and `simulate_module_main`

google / xls

XLS: Accelerated HW Synthesis

http://google.github.io/xls/

Apache License 2.0

1.22k stars 180 forks source link

Use same flag names for equivalent inputs in `eval_proc_main` and `simulate_module_main` #1644

Closed hzeller closed 2 weeks ago

hzeller commented 1 month ago

Low prio, just to not forget.

To read channel inputs to simulate, eval_proc_main uses --inputs_for_all_channels=<filename> while the equivalent in simulate_module_main is called --channel_values_file=<filename>.

There are probably other inconsistencies in names of flags across tools.

hzeller commented 2 weeks ago

A lot of this work has been done in #1645, establishing --testvector_testproto and using that for all the fuzzer output (and it was collecting all the submits, even though some would be more appropriately added here). Let's close this to not have two issues with somewhat overlapping objectives.