search

google / xls

XLS: Accelerated HW Synthesis
http://google.github.io/xls/
Apache License 2.0
1.22k stars 180 forks source link

[public:c_api] Add some missing symbols, make DSO targets, make test that symbol list matches .o #1665

Closed cdleary closed 1 month ago

cdleary commented 1 month ago

This should help minimize divergences with my DSO release branch -- I think the targets are reasonable to live upstream. These are the DSOs that get pulled in the Rust crate for linkage.

We can mark the targets as manual in copybara if necessary?

cc @proppy

proppy commented 1 month ago

Merged w/ https://github.com/google/xls/commit/df5c1f919382af89a7bfe286e82ad2c932f6b25e, thanks @hongted !

hongted commented 1 month ago

Merging required making changes to fix compatibility with internal build system. Notably, rules that aren't compatible have been moved into a macro within https://github.com/google/xls/blob/main/xls/public/xls_public_macros.oss.bzl

cdleary commented 1 month ago

Merging required making changes to fix compatibility with internal build system. Notably, rules that aren't compatible have been moved into a macro within https://github.com/google/xls/blob/main/xls/public/xls_public_macros.oss.bzl

Thanks, the scheme seems workable. I'll merge back and confirm.