[public:c_api] More type APIs.

cdleary commented 1 month ago

Note that this makes the ImportData take a defensive copy of additional search paths. This is a long-lived context-like object so it should increase safety / ease of use and not change much resource-wise. (I had previously accidentally written a use-after-free against this API since it previously captured the Span.)

Add more TypeDim-oriented APIs.
xls_bits_get_bit_count API and fix xls_dslx_type_info_get_type_struct_member
Add ability to get at underlying TypeAnnotation node in an enum def.
Add a bunch more APIs and a test for TypeRefs.

cdleary commented 1 month ago

Looks like this landed in https://github.com/google/xls/commit/85477aece89cadc21b5696ee06a83cc5877c68b4 but copybara didn't close out the PR?

proppy commented 1 month ago

Looks like this landed in 85477ae but copybara didn't close out the PR?

Yes, I think that's because there was some extra changes (comments) that got added after it got submitted internally.

google / xls

[public:c_api] More type APIs. #1672