search

googleads / googleads-php-lib

Google Ad Manager SOAP API Client Library for PHP
Apache License 2.0
656 stars 769 forks source link

Upgrade guzzlehttp/psr7 #769

Closed raalderink closed 1 year ago

raalderink commented 1 year ago

The guzzlehttp/psr7 library has had a major release in 2021, which should solve a lot of deprecations. Currently, the googleads-php-lib is the only library that is preventing us from upgrading and fixing those deprecations.

In that major, all functions in the GuzzleHttp\Psr7 namespace have been removed. This library does use those a couple times, so those will need refactoring for compatibility.

PierrickVoulet commented 1 year ago

Hi @raalderink - Thank you for suggesting this upgrade. This would be a breaking change so we will carefully consider this for newer versions.

leongersen commented 1 year ago

This upgrade will be backward compatible. PR #732 is open, implementing this.

PierrickVoulet commented 1 year ago

We would need to upgrade the current constraint from 1.2 to 1.7 to ensure access to the static API which may break some users.

PierrickVoulet commented 1 year ago

This is fixed starting with v60.