Create exception class for default credentials not found

googleapis / google-auth-library-ruby

Google Auth Library for Ruby

Apache License 2.0

471 stars 254 forks source link

Create exception class for default credentials not found #380

Closed bouk closed 2 years ago

bouk commented 2 years ago

Part of https://github.com/googleapis/google-auth-library-ruby/issues/304

Potentially we should make Google::Auth::Error a subclass of RuntimeError so we don't break backwards compatibility?

viacheslav-rostovtsev commented 2 years ago

Thank you for submitting this PR. The new error should definitely be a subclass of RuntimeError. That and fixing the rubocop errors from the CI should make it OK to merge.

NivedhaSenthil commented 2 years ago

@bouk gentle follow up to see if you are still looking at this ?

bajajneha27 commented 2 years ago

Hi @bouk I'm closing the PR due to inactivity. Please feel free to reopen it if you still want to continue working on it.