spanner: PartitionReadUsingIndexWithOptions does not consider transaction level read options

googleapis / google-cloud-go

Google Cloud Client Libraries for Go.

https://cloud.google.com/go/docs/reference

Apache License 2.0

3.72k stars 1.27k forks source link

spanner: PartitionReadUsingIndexWithOptions does not consider transaction level read options #9112

Open harshachinta opened 9 months ago

harshachinta commented 9 months ago

https://github.com/googleapis/google-cloud-go/blob/379d3df8ae9463dcd3ec28fc695b0e658ddeb2a1/spanner/batch.go#L119

The above PartitionReadUsingIndexWithOptions considers only request level ReadOptions, but ignore the readOptions set at client level (i.e. t.ReadOnlyTransaction.txReadOnly.ro)

harshachinta commented 9 months ago

I will work on the fix and create a PR soon.