googleapis / google-cloud-node

Google Cloud Client Library for Node.js
https://cloud.google.com/nodejs
Apache License 2.0
2.93k stars 598 forks source link

Fix the support for phonemes and fix your github actions #5833

Closed sofisl closed 1 week ago

sofisl commented 1 week ago

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

image

image

https://gist.github.com/jefer94/c98a9fb64987cf135b6df524b6de5056

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

<speak>
      <phoneme alphabet="ipa" ph="soso"></phoneme>
</speak>
  1. Go to https://console.cloud.google.com/speech/text-to-speech
  2. Write that input on SSML
  3. Click play button, each time you will heart nothing

A clear and concise description of what the bug is, and what you expected to happen.

In this case, reproduce /soso/ but really I want Text to Speech can reproduce all phonemes, right now it only support a small IPA subset

Also the bot is closing issues that DON'T REQUIRE A REPRODUCTION URL, fix your workflow, I'm providing a URL with information provided in the issue

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

Because I wrote an IPA reader, and if Text to Speech doesn't support it, I can't use Text to Speech

cc @jefer94

github-actions[bot] commented 1 week ago

Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)

sofisl commented 1 week ago

Hi @jefer94! Thank you for submitting this bug. Unfortunately this bug is related to the API, not the library itself. Please open a ticket with the API.

As for your other issue, I will keep it open - thank you for testing our issue templates. I apologize for the inconvenience. I will fix the automation as well as add tests. Thank you.