search

googleapis / java-spanner

Apache License 2.0
55 stars 110 forks source link

Library Compatibility with Protobuf-Java 4.26.x+ #3113

Closed lqiu96 closed 4 days ago

lqiu96 commented 4 months ago

Protobuf has released v26.x+ which introduces a bunch of breaking changes for Protobuf-Java. Release notes for the version can be found at https://github.com/protocolbuffers/protobuf/releases/tag/v26.0

We have identified the generated SingerProto.java from singer.proto has a bunch of references to removed methods.

The generated proto files should be re-generated with the latest protoc version (i.e. 3.25.x+). Investigate if the proto file needs to be updated (it has a proto2 syntax) before re-generating.

See this doc for more information.

lqiu96 commented 2 weeks ago

@harshachinta Protobuf-Java 4.27.4 was released (https://github.com/protocolbuffers/protobuf/releases/tag/v27.4) which should have backwards compatibility with Protobuf-Java v3.25.x. Would you be able to re-generated the above protos with the Protoc 25.4 and then close this issue again?

lqiu96 commented 4 days ago

Actually, on a second look 3.25.1 gen code should be compatible with 4.27.4 runtime. Closing.