Failing to use CC's seems to cause the changes in the commit to be ignored when generating releases - Githubissues

googleapis / release-please-action

automated releases based on conventional commits

Apache License 2.0

1.69k stars 209 forks source link

Failing to use CC's seems to cause the changes in the commit to be ignored when generating releases #1042

Open wesleytodd opened 1 week ago

wesleytodd commented 1 week ago

Environment details

Programming language: JS
OS: n/a
Language runtime version: n/a
Package version: n/a

Steps to reproduce

Commits not following CCs have now twice not generated releases for us while ones which do work as expected. In the logs we see the following:

Building candidate release pull request for path: packages/turbo-task
❯ type: node
❯ targetBranch: main
❯ commit could not be parsed: 9dd27740f2cc17b6467f3327aaa09dec1296131f add support for newt vars and remove log order grouping (#225)
❯ commits: 0
✔ Considering: 0 commits
✔ No commits for path: packages/turbo-task, skipping

Despite that commit having changes to two applicable packages:

$git --no-pager show --name-only 9dd27740f2cc17b6467f3327aaa09dec1296131f
commit 9dd27740f2cc17b6467f3327aaa09dec1296131f (main)
Author: <redacted>
Date:   Mon Oct 7 16:11:31 2024 -0700

    add support for newt vars and remove log order grouping (#225)

packages/turbo-task/lib/task.js
plugins/plugin-turbo/turbo-json.js

wesleytodd commented 1 week ago

It is possible this is miss-attributed to the commit format and that log. We found another case where it was happening with the chore: prefix. May need some more debugging to see why this commit (and a few others) are not being correctly detected while others are.