googlearchive / appengine-php-wordpress-starter-project

Starter project for running WordPress on Google Cloud Platform
366 stars 226 forks source link

removes zip blobs #55

Closed maxhille closed 6 years ago

maxhille commented 8 years ago

I see no point in providing binary blobs:

tmatsuo commented 8 years ago

Hi @maxhille First of all, thanks for the contribution!

I have a new plan for supporting WordPress on App Engine standard. I have already implemented the helper script for App Engine flexible environment at: https://github.com/GoogleCloudPlatform/php-docs-samples/tree/master/appengine/flexible/wordpress

My plan is to add App Engine standard support to that helper script. So I would rather focus on the new setup script rather than merging all of yours.

WDYT?

Also, can you sign the Google Corporate CLA at: https://cla.developers.google.com/ ?

Thanks!

maxhille commented 8 years ago

I just signed the CLA.

The new starter projects looks good. I think this old one should be deleted then as not to point people in the wrong direction.

tmatsuo commented 8 years ago

@maxhille

Thanks. I think those zip files are used in the quickstart page, although I agree we should use files on releases for this purpose. Let me talk with this project's maintainer.

BTW, now the new script supports App Engine standard environment too. I wrote a blog post about it: https://wp.gaeflex.ninja/2016/04/07/running-wordpress-on-app-engine-standard-environment/

Re: deleting this repo Agreed. I will try to deprecate this repo once the new script is proven to be useful.

maxhille commented 8 years ago

@tmatsuo The zips are indeed used on the quickstart page, but not on the project's README steps. Those two should be kept in sync I think. And to reduce complexity and have a simple solutions, maybe the README's steps should be put on the quickstart page (is that automatable?). That way no one would miss the zips. I think having to clone git repos is fine in today's world for devs.

maxhille commented 6 years ago

closing due to obsolescense