googlearchive / caja

Caja is a tool for safely embedding third party HTML, CSS and JavaScript in your website.
Apache License 2.0
1.13k stars 113 forks source link

"ant runtests" get stuck #1997

Closed erights closed 8 years ago

erights commented 8 years ago

"ant runtests" consistently gets stuck in get-scan-min

guest-scan-min Failure 800000 ms passed while waiting for: completion (Remaining elements = [

])

junit.framework.AssertionFailedError: 800000 ms passed while waiting for: completion (Remaining elements = [

]) at com.google.caja.plugin.BrowserTestCase.countdown(BrowserTestCase.java:262) at com.google.caja.plugin.BrowserTestCase.waitForCompletion(BrowserTestCase.java:222) at com.google.caja.plugin.BrowserTestCase.driveBrowser(BrowserTestCase.java:209) at com.google.caja.plugin.BrowserTestCase.runBrowserTest(BrowserTestCase.java:130) at com.google.caja.plugin.CatalogTestCase.runTest(CatalogTestCase.java:34) at com.google.caja.plugin.CatalogRunner$1.evaluate(CatalogRunner.java:94) at com.google.caja.plugin.CatalogRunner.runChild(CatalogRunner.java:88) at com.google.caja.plugin.CatalogRunner.runChild(CatalogRunner.java:42)

erights commented 8 years ago
screen shot 2016-02-19 at 6 18 11 pm
kpreid commented 8 years ago

Thanks for filing this — it's another thing I've hit myself and forgot to write down. Though your screenshot shows a different place (related to iterators IIRC).

Do you confirm it does not hang on Chrome (ant brtest -Dtest.browser=chrome)?

(By the way, to finish running other tests faster than the timeout, you can close the hung browser window.)

erights commented 8 years ago

ant brtest -Dtest.browser=chrome

I confirm that it does not stuck. However, it does give two other errors that are unrelated to guest-scan-min. Attached.

0_MainBrowserTest-err.txt screen shot 2016-02-20 at 3 30 02 pm screen shot 2016-02-20 at 3 30 20 pm screen shot 2016-02-20 at 3 30 38 pm

kpreid commented 8 years ago

The hang was fixed in commit f94c71cbc0640532ecd62e734fd7ea8ae7379df0.