Open ryansolida opened 9 years ago
Should check and see if this was fixed in generator-angular first. Probably about time to merge the upstream again.
Looks like it was fixed in generator-angular. https://github.com/yeoman/generator-angular/commit/209100d95f902d4c2efa47e3609143c1175b181f
Should be issue be fixed in the current version? I just installed and allowed overwrite of the bower file, but I don't seem to be getting any styling from bootstrap. If not, is there some quick fix to this?
What's your bower.json look like? Here's mine after a vanilla install and additional override that works OK.
{
"name": "aftest",
"version": "0.0.0",
"dependencies": {
"angular": "^1.3.0",
"firebase": "2.2.2",
"angularfire": "1.0.0",
"bootstrap": "^3.2.0",
"angular-animate": "^1.3.0",
"angular-cookies": "^1.3.0",
"angular-resource": "^1.3.0",
"angular-route": "^1.3.0",
"angular-sanitize": "^1.3.0",
"angular-touch": "^1.3.0"
},
"devDependencies": {
"mockfirebase": "0.11.0",
"angular-mocks": "^1.3.0"
},
"appPath": "app",
"moduleName": "aftestApp",
"overrides": {
"bootstrap": {
"main": [
"dist/js/bootstrap.js",
"dist/css/bootstrap.css",
"less/bootstrap.less"
]
}
}
}
My mistake, I didn't write the overrides manually, I thought it would be done during install. It works now! Thanks a lot!
On generating a new project, the version of bootstrap (if required) is currently defaulting to 3.3.5 which breaks wiredep. The fix (as in the Bootstrap release notes: http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/) is to add an override block to bower.json. I'm happy to submit a pull request with the change but wanted to at least run it here first in case it's already there and I'm missing something.