googlecreativelab / ar-drawing-java

A simple AR drawing experiment build in Java using ARCore.
https://experiments.withgoogle.com/ar/arcore-drawing
Apache License 2.0
416 stars 96 forks source link

Avoid using floats due to issue on Exynos devices #7

Closed vanaf closed 6 years ago

vanaf commented 6 years ago

Fixes issue https://github.com/googlecreativelab/ar-drawing-java/issues/2

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
vanaf commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

brijeshshah13 commented 6 years ago

Fixes #5 as well. @HalfdanJ I recommend you to merge this PR, as the app sometimes crashes due to the error mentioned in the logs of the issues.

HalfdanJ commented 6 years ago

Thanks!