googlecreativelab / open-nsynth-super

Open NSynth Super is an experimental physical interface for the NSynth algorithm
Apache License 2.0
2.42k stars 270 forks source link

Add support for MIDI running status. Add support for zero velocity n… #73

Closed lefty71 closed 5 years ago

lefty71 commented 5 years ago

Fix support for high-end midi controllers by adding support for MIDI running status and for zero velocity note-on messages. References: Page 5 of MIDI 1.0 Detailed Specification 4.2

This should resolve https://github.com/googlecreativelab/open-nsynth-super/issues/32

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
lefty71 commented 5 years ago

I signed it! (Actually I just fixed my registration with Google GitHub)

googlebot commented 5 years ago

CLAs look good, thanks!