googlefonts / Gulzar

Nastaliq font
https://gulzarfont.org
SIL Open Font License 1.1
40 stars 7 forks source link

Dot positioning and collision issues #49

Open saadatm opened 2 years ago

saadatm commented 2 years ago

Dot positioning and collision bugs that I observed in the Urdu translation of Gulzar's website (in Firefox 101.0.1 on a Windows 10 machine). I used the version of Gulzar that was generated in this GitHub Action run.

String Screenshot Comment
تقریباً image This word is also used in one of the promo images (which are gorgeous, by the way). However, in that image, there is no collision among the dots, so not sure what's happening. Perhaps, the font version which was used to create the image did not have the collision, but it later regressed?
کو بخوبی image Fixed (tested with the font built after https://github.com/googlefonts/Gulzar/commit/f09210d08fbff35b45ef499a306feba05feba711)
اب بھی image The dot for ب in بھی is usually well-behaved at other places, but in this particular sequence, it is too close to the ب in اب.

Fixed (tested with the font built after https://github.com/googlefonts/Gulzar/commit/f09210d08fbff35b45ef499a306feba05feba711)
سمپکنز کمبینیشنز ایپلکیشنز سبز image image image image Dot of ز is too far way and sometimes collides with subsequent words. (The first three words are transliterations, but سبز is Urdu for green and I actually used a synonym (ہرا/ہرے) in the translation to avoid having the dot of ز in سبز collide with the next word.) Generally, some sequences that end with نز or بز disturb the dots, like خنز طنز سبز. Same with sequences ending with نڑ, where the dot of ن and small ط of ڑ seem to be flying away. Also note the collision of ا and dots of ے in ایپلیکیشنز, and the cluster of dots when ایپلیکیشنز is followed by بھی.
زیرِ image The kasra is colliding with dots of ی.
نئی نئے image image Dot of ن is too far up. It should be closer to its base, and the mark of hamza may be moved up instead.
پیوستہ image image Not sure what's hppening here. It appears fine at one place, but at another place its dots are colliding. (Even when there is no collision, it will look better if the dots of ی are moved towards up-left.)
نتیجہ image This isn't bad, but will look better if the dot of ن could be brought closer to its base.
simoncozens commented 2 years ago

This word is also used in one of the promo images (which are gorgeous, by the way). However, in that image, there is no collision among the dots, so not sure what's happening. Perhaps, the font version which was used to create the image did not have the collision, but it later regressed?

I suspect this was caused by 79c98f6. I'll see if we can find a happy medium.

saadatm commented 2 years ago

I suspect this was caused by https://github.com/googlefonts/Gulzar/commit/79c98f610f4648ca52bd0f59ce2c752c487c1add. I'll see if we can find a happy medium.

This issue is also reproducible with the version of Gulzar currently being used for the website, so its cause is probably older than that commit.

saadatm commented 2 years ago

Not sure what's hppening here. It appears fine at one place, but at another place its dots are colliding. (Even when there is no collision, it will look better if the dots of ی are moved towards up-left.)

Found some more info: Dot collision happens if پیو is preceded by any of د ر و or ہ. Screenshot below:

paiwasta

saadatm commented 2 years ago

After the recent round of bug squashing by @simoncozens, I was curious to see if it also affected any of the problems reported in this issue. کو بخوبی and اب بھی are now fixed. 👍

Screenshot 2022-11-10 at 09-48-22 گُلزار نستعلیق اُردو فونٹ

Screenshot 2022-11-10 at 09-49-02 گُلزار نستعلیق اُردو فونٹ

simoncozens commented 2 years ago

Very nice!

dboyk commented 2 years ago

Very excited for your work! I’m encountering some dot positioning and collision issues when ز is preceded by ب, ن, or ہ. Here are some examples (some are real Urdu words, some not):

Screen Shot 2022-11-28 at 9 55 17 AM Screen Shot 2022-11-28 at 9 55 29 AM Screen Shot 2022-11-28 at 9 55 36 AM Screen Shot 2022-11-28 at 9 55 42 AM Screen Shot 2022-11-28 at 9 58 50 AM Screen Shot 2022-11-28 at 9 58 55 AM Screen Shot 2022-11-28 at 9 59 31 AM Screen Shot 2022-11-28 at 9 59 50 AM Screen Shot 2022-11-28 at 9 59 54 AM Screen Shot 2022-11-28 at 10 08 29 AM Screen Shot 2022-11-28 at 10 08 33 AM Screen Shot 2022-11-28 at 10 08 33 AM Screen Shot 2022-11-28 at 10 20 39 AM
dboyk commented 2 years ago

Quick followup – ڑ seems to have the same issues:

Screen Shot 2022-11-28 at 12 35 18 PM Screen Shot 2022-11-28 at 12 35 14 PM