googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
85 stars 14 forks source link

[fea-rs] Better handling of featureNames & cvParam #1021

Closed cmyr closed 1 month ago

cmyr commented 1 month ago

Previously we would error if there were more than one of these blocks, but the spec merely says that they must occur before any rules.

This now supports multiple featureNames blocks, and matches the behaviour of fonttools (last writer wins).

For CvParameters, we will only look at the first such block, and skip the rest; no source in our collection has multiple such blocks defined within a given feature, and updating the logic is more complicated so I would like to defer it for now.