googlefonts / gideon

Gideon fonts
SIL Open Font License 1.1
1 stars 2 forks source link

L1 Mastering Font checklist #2

Open vv-monsalve opened 3 years ago

vv-monsalve commented 3 years ago

L1 Mastering Font checklist

Diacritics

Glyphs & Outlines

OT Features

Testing changes

vv-monsalve commented 3 years ago

Hi @crystaltype, I've performed some fixes needed to the spacing and kerning for Gideon covering the main cases and creating the kerning groups. However, after creating the Browser Images there are a lot of undesired 'exceptions' kerning cases that are still causing some spacing issues. E.g. Sample Text Uppercase text in the images.

Please take the latest file in repo and make sure that the exception cases are no longer working (yellow ones in the image). I deleted some of them from the Kerning palette, but the actual values remained in the font, so it would need to be a case by case revision.

Screen Shot 2021-08-11 at 21 31 15
crystaltype commented 3 years ago

@vv-monsalve Hello Viviana, I've deleted all kerning exception and made a pull request here: https://github.com/googlefonts/gideon/pull/7

vv-monsalve commented 3 years ago

Hi @crystaltype, did you apply a script to change the kerning values? After merging the PR with the kerning job on it, there are new kerning pairs that shouldn't be included, e.g. the -19 value between n n.

Before

Screen Shot 2021-08-17 at 10 37 00

After

Screen Shot 2021-08-17 at 10 36 52

As mentioned above it required a case by case revision as automatic actions weren't doing the job properly. So for example if m has sidebearings arithmetics related to n and belong to the same kerning group, there shouldn't be different kerning values for the same letters, e.g. o n and o m

Screen Shot 2021-08-17 at 13 18 44

I'll go back to the previous version, make some adjustments and push again the file.