search

googlefonts / picosvg

Helps simplify SVG files. Intended for use as part of a font build.
Apache License 2.0
142 stars 12 forks source link

Allow vendor style pass through #295

Closed NightFurySL2001 closed 1 year ago

NightFurySL2001 commented 1 year ago

fix #293

anthrotype commented 1 year ago

A test would be nice too

anthrotype commented 1 year ago

Also maybe please add references to spec e.g. https://www.w3.org/TR/CSS2/syndata.html#vendor-keywords

NightFurySL2001 commented 1 year ago

What type of test should I add for this?

anthrotype commented 1 year ago

What type of test should I add for this?

in tests/svg_test.py there are some tests for parse_css_declarations function; you could add a couple tests there verifying that the attributes that start with "-" end up in the "unparsed" bit

anthrotype commented 1 year ago

thanks, I can pick up from here

NightFurySL2001 commented 1 year ago

Thanks a lot!

anthrotype commented 1 year ago

@NightFurySL2001 https://github.com/googlefonts/picosvg/releases/tag/v0.21.0

NightFurySL2001 commented 1 year ago

Thank you! This comment in test could be updated too: https://github.com/googlefonts/picosvg/blob/2b3874697828afde351898e1e11587f462e1f00c/tests/svg_test.py#L419

anthrotype commented 1 year ago

well, yeah.. but it still refers to the issue where we discussed it so it's ok