googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
152 stars 43 forks source link

Old kern writer: Convert groups back #845

Closed madig closed 6 months ago

madig commented 6 months ago

This fixes an oversight in https://github.com/googlefonts/ufo2ft/pull/841.

The kerning pair sides have to be converted back to fea AST classes. Since groups aren't filtered in getVariableKerningPairs, it should hopefully be okay to just grab them by their members 😬

madig commented 6 months ago

I don't understand the test failure... it werks on my local machine? Is there a accidental un-sorting problem hiding in there?

anthrotype commented 6 months ago

You could try re running the CI manually If it then passes we know there is some in-determinism hiding somewhere

madig commented 6 months ago

Ah yes, running it multiple times locally makes it crash occasionally. Let's see.

anthrotype commented 6 months ago

feel free to merge this when ready