Make Radius required, use Black as colour in Circle

googlemaps / android-maps-compose

Jetpack Compose composables for the Maps SDK for Android

https://developers.google.com/maps/documentation/android-sdk/maps-compose

Apache License 2.0

1.17k stars 142 forks source link

Make Radius required, use Black as colour in Circle #531

Open lucanicoletti opened 8 months ago

lucanicoletti commented 8 months ago

Both Polygon and Polyline use Black as the default colour, making them visible on the Map when used without specifying a colour. Circle by default draws a 0-radius circle. If the radius is specified, it still draws a Transparent circle on the map, making it not visible. Update the Circle function to require the radius to be specified, and change the default colour to Color.Black, as used in other Composable for Maps. As it was a simple edit, I've done it already and I would be ready to open the PR if this is agreed upon

wangela commented 8 months ago

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.

@lnicolet Thank you for opening this issue. 🙏 Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

lucanicoletti commented 7 months ago

Is there any update on this? I'm happy to make the changes and open a PR request.

kikoso commented 2 days ago

Hi @lucanicoletti. This is a reasonable proposal. Feel free to make a PR following our contribution guidelines. A default color of Black and a radius of 10.0 seem like reasonable values.