search

googlemaps / google-maps-services-python

Python client library for Google Maps API Web Services
Apache License 2.0
4.56k stars 1.31k forks source link

Updated encoding #500

Closed ThugPigeon653 closed 1 year ago

ThugPigeon653 commented 1 year ago

I have made encoding (in client) compatible with both Python 2 and Python 3. The existing encoding was the correct approach for Py2, but was not appropriate for python3, because it had removed the data type. So as to not cause any issues with the python3 interpreter, urlencode_params() checks for a str type instead of unicode. Python3 shouldn't really need encoding here, but unlike 2, it will handle unnecessary encoding fine - so I have enforced it to always encode for python3

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ThugPigeon653 commented 1 year ago

Closing PR, I will open a new one with CLA sorted out