googlemaps / ios-places-sdk

Apache License 2.0
9 stars 2 forks source link

[Feature]: Add Privacy Manifest to GooglePlaces #5

Closed micahcharlesbrown closed 1 month ago

micahcharlesbrown commented 7 months ago

Is your feature request related to a problem? Please describe. Apple is requiring app developers and third party SDKs to declare their use of the Required Reason APIs via a Privacy Manifest.

Is Google Places planning to add this to the ios SDK? And if not, could it be added? Thanks!

Privacy Manifest - Apple Documents Required Reason API Documents

Describe the solution you'd like

Privacy manifest for required reason api uses added

Thanks!

wangela commented 7 months ago

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.

@micahcharlesbrown Thank you for opening this issue. 🙏 Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

micahcharlesbrown commented 4 months ago

Any updates on this? (embarrassing wrong initial name, sorry, was adding a few issues to different repos where this is experienced)

mammaiap commented 4 months ago

when will be the next release with "Privacy manifest" support?

wangela commented 4 months ago

The Google Maps Platform team is aware of Apple's announcements regarding third-party SDK privacy manifest and signature and required reason APIs. Although none of the Google Maps Platform SDKs for iOS are listed on Apple's page of "SDKs that require a privacy manifest and signature" as of the date of this message, the team is working on understanding and fulfilling the requirements in anticipation of Apple's requirements of apps that use Google Maps Platform SDKs for iOS. We cannot give a date when a version of the SDK that meets the requirements will be released.

pehhan commented 3 months ago

We thought we had declared all the info needed for our app and updated the 3rd party libs that were required but we got a warning from Apple when uploading a build with Google Places included, complaining that we were using NSPrivacyAccessedAPICategoryFileTimestamp without declaring the required reason.

Using the binary-based scanner from here: https://github.com/Wooder/ios_17_required_reason_api_scanner, gave the following results:

Used symbols in binary ./Pods/GooglePlaces/Frameworks/GooglePlaces.xcframework/ios-arm64_x86_64-simulator/GooglePlaces.framework/GooglePlaces: NSURLContentModificationDateKey, NSUserDefaults, stat
Used symbols in binary ./Pods/GooglePlaces/Frameworks/GooglePlaces.xcframework/ios-arm64/GooglePlaces.framework/GooglePlaces: NSURLContentModificationDateKey, NSUserDefaults, stat

After temporarily removing the Google Places lib and uploading a new build to test it, we no longer got any warning.

wangela commented 3 months ago

Thanks for sharing this feedback @pehhan! It's hard for us to predict what the App Store reviews will say in advance so it's helpful for developers to report the feedback they're getting.

stsc3000 commented 3 months ago

@wangela The installation documentation now appears to include a step for adding the Apple Privacy Manifest file.

Is this a first step towards a solution or already something we should apply? Many other packages do include the PrivacyInfo.xcprivacy file in their distribution and as such do not require a separate file, e.g. Google Sign In.

wangela commented 3 months ago

The installation instructions for Google Maps Platform SDKs for iOS now have download links and instructions for manually adding Privacy Manifest files for use with the latest versions of the SDKs. If you receive feedback from Apple regarding the contents of these privacy manifests, please report that feedback on this Issue Tracker issue. Find instructions and manifests for each SDK at the links below:

@stsc3000 yes, this is a first step. Further commentary is on the issue tracker issue.

wangela commented 1 month ago

This is a courtesy copy of the closing comment on the Public Issue Tracker issue.