search

googlesamples / unity-jar-resolver

Unity plugin which resolves Android & iOS dependencies and performs version management
Other
1.21k stars 336 forks source link

[FR] Stop Requesting Enabling Auto-Resolution for Android Resolver When Already Denied #689

Open SCastanedaMunoz opened 2 weeks ago

SCastanedaMunoz commented 2 weeks ago

[READ] Guidelines

When filing a feature request please make sure the issue title starts with "FR:".

A good feature request ideally

Once you've read this section, please delete it and fill out the rest of the template.

Feature proposal

We currently disable auto-resolution for the EDM since it overrides any existing private maven repositories or custom modifications to gradle files. However, when disabling the auto-resolution of dependencies, a popup appears every time we compile/modify code. The popup ask to enable auto resolution, when denying this, nothing happens and the popup appears on the next compilation.

Enabling auto-resolution and disabling it seems to make the pop-up disappear for a while but it does not last long.

SCastanedaMunoz commented 2 weeks ago
Screenshot 2024-06-13 at 4 34 29 PM

This is the pop-up in question, pressing "Disable" effectively does nothing. Then the pop-up just keeps spamming on every code change. 👎🏻

SCastanedaMunoz commented 1 week ago

Any updates on this? The EDM keeps enabling auto-resolution by itself, which is very annoying and blocks development a lot.

argzdev commented 1 week ago

Hey @SCastanedaMunoz, thanks for reaching out. This sounds like a bug, however after disabling auto-resolution, I'm not encountering this behavior when I do any codes with our Unity quickstart. I wonder if there are extra steps to exhibit this behavior. Any chance you could provide a minimal reproducible example so we can speed up the investigation? Thanks!

SCastanedaMunoz commented 1 week ago

Taking a look at the GvhProjectSettings.xml I can see that pressing Disable on the dialog does not actually change the flag GooglePlayServices.AutoResolutionDisabledWarning, so it remains true. I have changed this flag manually to False for the time being. I am trying multiple scenarios to see if any actions cause this flag to flip back to True

SCastanedaMunoz commented 1 week ago

Additional info: I rant some of my Unit tests from my project and most of the settings from GvhProjectSettings.xml got wiped. I think this explains why the popup keeps appearing, something seems to be causing the GvhProjectSettings.xml to get reset. This means that every time I build/run unit tests on my devices, the settings get wiped and have to disable the auto-resolution every time.

SCastanedaMunoz commented 1 week ago

Any updates on this? 👀

a-maurice commented 6 days ago

For the GvhProjectSettings.xml issue, that should hopefully be resolved with the latest release, 1.2.180, which fixed a bug that was causing that file to be overwritten sometimes. For the GooglePlayServices.AutoResolutionDisabledWarning not being set in code, it isn't meant to, as all that does it toggle the warning that appears in the log, and is meant to require manual disabling in the settings.

Looking at the logic for the original pop up, it does seem to be setting the correct fields if Disable is selected: https://github.com/googlesamples/unity-jar-resolver/blob/a3a46e587d0ae9396f3ca39fb67cc06398e8e9da/source/AndroidResolver/src/PlayServicesResolver.cs#L1930

My hope is that maybe the GvhProjectSettings.xml issue of it being overwritten was causing your problem, as similar to @argzdev, I haven't been able to reproduce it prompting multiple times.

SCastanedaMunoz commented 4 days ago

Thanks, we will take a look at the 1.2.180 release and see if this fixes our issues.