search

googlestadia / PorQue4K

Los arcoiris son mejores en 4K. #BlackLivesMatter
Apache License 2.0
20 stars 7 forks source link

Add a control for sharpness in CAS upscaling #39

Closed apazylbe closed 4 years ago

ndeakin commented 4 years ago

If I understand correctly, this is intended to add the control for sharpness, but it doesn't cause it to have any affect yet - correct?

robbiesri commented 4 years ago

If I understand correctly, this is intended to add the control for sharpness, but it doesn't cause it to have any affect yet - correct?

Actually, it does. Take a look at how UpdateCASConstants is implemented: https://github.com/googlestadia/PorQue4K/blob/209ba90a35f05df0be68df586c9e184183ed8263/src/app/CAS.cpp#L27

It packs the sharpness arg into the constant buffer that the CAS shader uses.

ndeakin commented 4 years ago

ahhhh got it, makes sense, thanks for the clarification!