Open dominikschulz opened 3 years ago
hihi, can i check if this change is still required? i would like to contribute to this directory as part of this year's hacktoberfest
@JoelLau this is still in need of better tests. But I have no idea how tricky this is since it's a lot of user interactions (terminal input). Feel free to a give it a try.
@dominikschulz having a little trouble with my local setup. do you happen to have come across this error before?
$ go run . setup
# github.com/kbinani/screenshot
../../../../go/pkg/mod/github.com/kbinani/screenshot@v0.0.0-20230812210009-b87d31814237/screenshot_darwin.go:10:9: error: 'CGDisplayCreateImageForRect' is unavailable: obsoleted in macOS 15.0 - Please use ScreenCaptureKit instead.
10 | return CGDisplayCreateImageForRect(display, rect);
| ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDirectDisplay.h:391:33: note: 'CGDisplayCreateImageForRect' has been explicitly marked unavailable here
391 | CG_EXTERN CGImageRef __nullable CGDisplayCreateImageForRect(
| ^
1 error generated.
@JoelLau that looks like a deprecation notice from Apple. We can try updating the screenshot package. If that doesn't work we should report the issue upstream.
I think it should work with the latest master, thanks https://github.com/kbinani/screenshot/pull/24 Sadly that project isn't tagging its releases.
The Onboarding Wizard is largely untested.
We should add some automated tests to capture the primary user journeys here.