search

gophish / api-client-python

A Python API Client for Gophish
MIT License
45 stars 48 forks source link

Envelope_sender of V12.0 not included #34

Open Creyox opened 2 years ago

Creyox commented 2 years ago

What version of Gophish are you using?: 12.0

Brief description of the issue: The documentation is not updated and does not include the added envelope_sender in V.12.0. Additionally, the envelope_sender can not be requested via the Python wrapper, it is not included in the template processed by the Python wrapper.

What are you expecting to see happen? : The Python wrapper shall return the envelope_sender when requesting a specific campaign / the template of it.

What do you see: A direct API call is possible and returns the envelope_sender, but the Python wrapper is not updated.

martinclauss commented 1 year ago

Please add envelope_sender to the model in https://github.com/gophish/api-client-python/blob/a4094b866293ae25c5425981d9e7fb405a7beebe/gophish/models.py#L339

Thanks! :)