gorhill / uBlock-for-firefox-legacy

uBlock Origin for Firefox legacy-based browsers.
GNU General Public License v3.0
201 stars 24 forks source link

Enable the syntax converter for more filters #324

Closed THEtomaso closed 2 years ago

THEtomaso commented 2 years ago

Reference: https://github.com/easylist/easylist/issues/10035#issuecomment-994794684

JustOff commented 2 years ago

danskebank.*##+js(remove-class, cookie-consent-banner-open, html)

Where does this rule come from? I do not see it in EasyList Cookie.

THEtomaso commented 2 years ago

https://github.com/easylist/easylist/blob/c2022168ac21d7e5f7b9118cb42651e3a6e134c9/easylist_cookie/easylist_cookie_specific_uBO.txt#L138

JustOff commented 2 years ago

I don't see this list mentioned anywhere in assets.json.

AroKol78 commented 2 years ago

https://github.com/gorhill/uBlock-for-firefox-legacy/blob/master/assets/assets.json#L202

JustOff commented 2 years ago

No, that corresponds to https://secure.fanboy.co.nz/fanboy-cookiemonster.txt, which is not easylist_cookie_specific_uBO.txt.

AroKol78 commented 2 years ago

chrome://ublock0/content/asset-viewer.html?url=fanboy-cookiemonster

haha1

THEtomaso commented 2 years ago

No, that corresponds to https://secure.fanboy.co.nz/fanboy-cookiemonster.txt, which is not easylist_cookie_specific_uBO.txt.

It's loaded through !#include easylist_cookie_specific_uBO.txt

Also, Easylist Cookie List is automagically loaded in Fanboy's Annoyance List, so the syntax converter needs to be enabled for that filter too!

JustOff commented 2 years ago

Ahh, my bad, now I see. Do we need to enable syntax converter for any other additional lists except EasyList Cookie and Fanboy's Annoyance?

THEtomaso commented 2 years ago

Fanboy's Social Blocking List: https://github.com/easylist/easylist/commit/1ff6f0c7ebbdd1a8f492e9eb9fa2e3895bdac798

AroKol78 commented 2 years ago

"adguard-spyware" --> AdGuard Tracking Protection

EDIT: https://github.com/gorhill/uBlock-for-firefox-legacy/issues/323

THEtomaso commented 2 years ago

AdGuard Social Media filter currently only has one rule, which needs to be converted too.

THEtomaso commented 2 years ago

"noConvert": really aren't used for that many filters. At this point, removing it all together might be the best solution.

..just make sure that the converter isn't interfering with My filters!

JustOff commented 2 years ago

Anything else?

At this point, removing it all together might be the best solution.

I don't think so.

THEtomaso commented 2 years ago

Guess we're OK :)

AroKol78 commented 2 years ago

how to force updates assets.json chrome://ublock0/content/asset-viewer.html?url=fanboy-cookiemonster I still have +js(rc, - not converted

JustOff commented 2 years ago

Purge all caches + Update now twice.

AroKol78 commented 2 years ago

i tried several (> 10) times before and now - it doesn't work on assets.json

THEtomaso commented 2 years ago

it doesn't work

Confirmed

AroKol78 commented 2 years ago

in "logger" show https://raw.githubusercontent.com/gorhill/uBlock-for-firefox-legacy/master/assets/assets.json

that is, maybe it doesn't convert lists as they are disabled by default

JustOff commented 2 years ago

that is, maybe it doesn't convert lists as they are disabled by default

Of course you should enable them, otherwise they are not downloaded and accordingly are not converted.

AroKol78 commented 2 years ago

we don't understand each other I turn on the list "EasyList Cookie", Purge all caches + Update now , close the browser with the list "EasyList Cookie" attached then next i start the browser and I still have +js(rc,

THEtomaso commented 2 years ago

I turn on the list "EasyList Cookie", Purge all caches + Update now , close the browser with the list "EasyList Cookie" attached then next i start the browser and I still have +js(rc,

Same here.

JustOff commented 2 years ago

It should be fixed now.