goru001 / inltk

Natural Language Toolkit for Indic Languages aims to provide out of the box support for various NLP tasks that an application developer might need
https://inltk.readthedocs.io
MIT License
824 stars 163 forks source link

fix requirements #72

Open Ishan-Kumar2 opened 3 years ago

Ishan-Kumar2 commented 3 years ago

Hi, The requirements mentioned in the setup.py file include typing which is redundant as it is included in the stdlib from python 3.5 onwards see here. Since iNLTK supports only Python >=3.6 installing typing causes an error. Also sklearn which is needed has been included. Let me know if I am wrong. Thanks!

utkarshgupta137 commented 3 years ago

@goru001 Please merge this

goru001 commented 3 years ago

Thanks @Ishan-Kumar2 for your contribution. Can you share a notebook showing the issue which this PR tries to solve? I was not able to reproduce the issue which you seem to be referring to.