Overhauled most of the tests already in use and fixed the broken tests. Most tests were not activating before due to a function naming error. The test_user() function is not the best as it functions purely by adding two new records, each with different users, then querying for the last record submitted by that user, then testing that the user's record matches the user object... This shouldn't mean much as it should be pulling the second-to-last record and checking what user object submitted it, however, Symfony was not cooperating with the user field, despite it existing everywhere. This will need to be discussed later in a group meeting.
There are no new warnings from scripts, however, there are two deprecation notices in the overviewControllerTest file which might cause issues later. Not needing a change at the moment, but should probably be looked into soon.
Fixes
Most function names, variable names, and comments have been updated to fit the style guide.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description
Overhauled most of the tests already in use and fixed the broken tests. Most tests were not activating before due to a function naming error. The test_user() function is not the best as it functions purely by adding two new records, each with different users, then querying for the last record submitted by that user, then testing that the user's record matches the user object... This shouldn't mean much as it should be pulling the second-to-last record and checking what user object submitted it, however, Symfony was not cooperating with the user field, despite it existing everywhere. This will need to be discussed later in a group meeting.
There are no new warnings from scripts, however, there are two deprecation notices in the overviewControllerTest file which might cause issues later. Not needing a change at the moment, but should probably be looked into soon.
Fixes
Most function names, variable names, and comments have been updated to fit the style guide.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: