search

goshippo / shippo-node-client

Shipping API Node.js library (USPS, FedEx, UPS and more)
https://goshippo.com/docs
MIT License
136 stars 54 forks source link

Typescript definitions #46

Open mderrick opened 5 years ago

mderrick commented 5 years ago

Are there any Typescript definitions expected in the future? Thanks!

dan-j commented 5 years ago

Can a maintainer confirm if they would accept a PR with a definition file? We're currently evaluating a couple of similar services. We don't mind contributing some definitions but don't want the full responsibility of maintaining it.

epistemancer commented 4 years ago

Sorry for the long response time on this. We'd gladly accept a PR for TypeScript definitions if anybody would like to contribute one. Otherwise, I'll try to commit them myself if I have time; it's a good suggestion.

kwent commented 3 years ago

Did anyone came across this and write them ? Much needed

saiichihashimoto commented 3 years ago

image

The repo hasn't been updated since April, hopes are low. Maybe someone will figure out a DefinitelyTyped solution.

architgarg commented 3 years ago

Huhh. Much needed thing!!

saiichihashimoto commented 3 years ago

Is this something that is being thought of? At the very least, is there work on a version being shipped within https://github.com/DefinitelyTyped/DefinitelyTyped? I doubt anyone from shippo is looking at this but hopefully someone can get something working there.

jbool24 commented 2 years ago

The Definitely Typed types weren't very good when I tried to use (not really up to date with the API version) so I have added my own definitions. The quality of mine is also probably not the best for general use but its enough to satisfy a bunch of situations. I'm willing to share in a Gist if anyone is interested. At least its a starting point. I might have time in the future to contribute to the Def Typed version if this is useful to anyone

https://gist.github.com/jbool24/93f017d4a496aac05655fcde0867a894

jrkienle commented 2 years ago

Can we get an update on this issue from any of the maintainers? TypeScript is rapidly growing in popularity and the current typings published do not work with the latest version of the package. Having typings included would be an amazing experience to have for those that use strict TypeScript

peterb0yd commented 2 years ago

Bump!

vyshakhbabji commented 2 years ago

Hi All, I recently joined Shippo as Dev Rel and will be looking into how to accommodate this request to support TypeScript. It might take some time for us to work on it, but @dan-j if you or anybody here wants to send a PR, would definitely be happy to review it and accept the PR. We will continue to support it and start to maintain all our SDKs with timely releases and support.

eparizzi-clevertech commented 1 year ago

We need Typescript support, even if it's partial for the moment.

enchorb commented 1 year ago

Any updates on this?

jbool24 commented 1 year ago

This was my workaround. Manually typed the API myself. Maybe it will help others while they get some official TS created (if ever)

The Definitely Typed types weren't very good when I tried to use (not really up to date with the API version) so I have added my own definitions. The quality of mine is also probably not the best for general use but its enough to satisfy a bunch of situations. I'm willing to share in a Gist if anyone is interested. At least its a starting point. I might have time in the future to contribute to the Def Typed version if this is useful to anyone

https://gist.github.com/jbool24/93f017d4a496aac05655fcde0867a894

acommodari commented 7 months ago

Any updates on this? i also noticed that the types on @types/shippo are not great and created a discussion here but not sure if those types are even being maintained...

jbool24 commented 3 months ago

UPDATE 04/01/2024

An update for anyone landing on this issue. I've spoken with reps and the do not maintain this repo anymore nor do they have any plans to pick up again. Unfortunately, you will have to create you own types in order to use this package as well as maintain the source yourself. They have also not even had the decency to archive this repo in order to let us know its dead.

You may be as upset as I am considering that Javascript is probably the largest community that could utilize a client library however they have made a clear decision to disregard that fact and ignore the community.

AdrianCollinsShippo commented 2 months ago

Thank you for bringing this up. Shippo is currently in the process of relaunching all our SDKs. We've recently introduced our new Python SDK, and the release of our new Node SDK is scheduled for the upcoming weeks.