goshops-com / clipshare

An incredibly simple, open-source alternative to Loom that only requires S3-compatible storage—no servers needed
https://github.com/goshops-com/clipshare
MIT License
339 stars 11 forks source link

Creating new tray.......... #13

Closed gabovj closed 2 months ago

gabovj commented 3 months ago
oi@fedora:~/Documents/clipshare$ npm start

> clipshare@1.0.0 start
> electron .

(node:501750) NOTE: The AWS SDK for JavaScript (v2) will enter maintenance mode
on September 8, 2024 and reach end-of-support on September 8, 2025.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check blog post at https://a.co/cUPnyil
(Use `electron --trace-warnings ...` to show where the warning was created)
App is ready
Creating new tray
Tray already exists, destroying old tray
Creating new tray

after this what should i do?

sjcotto commented 3 months ago

hi, do u see any errors? if not you should see a tray icon

sjcotto commented 3 months ago

if no error but icon don't appear, what operating system are u using?

gabovj commented 3 months ago

no error and no icon, i am using Fedora 40

sjcotto commented 3 months ago

What gui, gnome/kde?

On Sat, Aug 31, 2024, 8:21 PM gabovj @.***> wrote:

no error and no icon, i am using Fedora 40

— Reply to this email directly, view it on GitHub https://github.com/goshops-com/clipshare/issues/13#issuecomment-2323068943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TMFW4INKAPMOBRAILRW3ZUJFYLAVCNFSM6AAAAABNNM6NXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGA3DQOJUGM . You are receiving this because you commented.Message ID: @.***>

gabovj commented 3 months ago

GNOME Shell 46.4

sjcotto commented 3 months ago

Thanks, going to install a VM and test

On Sun, Sep 1, 2024, 1:18 PM gabovj @.***> wrote:

GNOME Shell 46.4

— Reply to this email directly, view it on GitHub https://github.com/goshops-com/clipshare/issues/13#issuecomment-2323413151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TMFQ664QM4HBUALZCEJDZUM43TAVCNFSM6AAAAABNNM6NXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGQYTGMJVGE . You are receiving this because you commented.Message ID: @.***>

sjcotto commented 2 months ago

interesting stuff, seems like gnome dosen't support tray icons anymore, there are a few extentions to add it

for example: https://extensions.gnome.org/extension/2890/tray-icons-reloaded/

gabovj commented 2 months ago

i will give it a try, let you know

sjcotto commented 2 months ago

Another thing I was thinking is to have a way to start it without tray icon, like open the window directly for OS that dosent have tray icons or users tha don't want it maybe is a good idea not sure, do u have a opinion on this?

On Sun, Sep 1, 2024, 11:39 PM gabovj @.***> wrote:

i will give it a try, let you know

— Reply to this email directly, view it on GitHub https://github.com/goshops-com/clipshare/issues/13#issuecomment-2323674967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TMFVOW3T5CVS3SG4S4RLZUPFX5AVCNFSM6AAAAABNNM6NXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGY3TIOJWG4 . You are receiving this because you commented.Message ID: @.***>

gabovj commented 2 months ago

it would be nice that option

sjcotto commented 2 months ago

ok, i just added this new env variable, it can be tested from the branch window-mode

here is a quick demo from virtual box: https://clipshare.gopersonal.com/01J6T7WE38H4893JWYYKQQNZ8X.webm

please confirm if this works for you from this branch and i will merge the PR, the new enviroment variable is

MODE=WINDOW
gabovj commented 2 months ago

It works perfect, thank you so much

sjcotto commented 2 months ago

Great news, PR merged

Thanks

On Mon, Sep 2, 2024, 9:39 PM gabovj @.***> wrote:

It works perfect, thank you so much

— Reply to this email directly, view it on GitHub https://github.com/goshops-com/clipshare/issues/13#issuecomment-2325417850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TMFTSU63HU2J2YASIVNTZUUAKVAVCNFSM6AAAAABNNM6NXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGQYTOOBVGA . You are receiving this because you commented.Message ID: @.***>