search

gosimple / slug

URL-friendly slugify with multiple languages support.
Mozilla Public License 2.0
1.15k stars 108 forks source link

New language: hu/hun/hungarian #65

Closed theriverman closed 2 years ago

theriverman commented 2 years ago

Adding support for the Hungarian (hu/hun) language

codecov[bot] commented 2 years ago

Codecov Report

Merging #65 (a17f6e3) into master (f347b0c) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a17f6e3 differs from pull request most recent head bbbac16. Consider uploading reports for the commit bbbac16 to get more accurate results

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
Coverage   100.00%   100.00%           
=========================================
Files            2         2           
Lines          135       135           
=========================================
Hits           135       135
Impacted Files Coverage Δ
languages_substitution.go 100.00% <100.00%> (ø)
slug.go 100.00% <100.00%> (ø)
matrixik commented 2 years ago

I saw that you did not add substitutions for & and @ so they will follow English (default) substitutions: '&' => "and", '@' => "at".

Thank you for this changes.

theriverman commented 2 years ago

I saw that you did not add substitutions for & and @ so they will follow English (default) substitutions: '&' => "and", '@' => "at".

Thank you for this changes.

We don’t really use & in Hungarian so the English substitution will be alright. The slug will remain readable for native speakers. Same applies to @. If others disagree, we can come back later and figure out something :)

Thanks for the quick review!