search

gpac / mp4box.js

JavaScript version of GPAC's MP4Box tool
https://gpac.github.io/mp4box.js/
BSD 3-Clause "New" or "Revised" License
1.92k stars 325 forks source link

improve group and property handling #332

Closed bradh closed 1 year ago

bradh commented 1 year ago

Prior to this change, property processing will throw if the association is not found in the item list. That can happen because the association is broken, and can also happen on a valid file if the property is associated with a group rather than a single item.

This change links the property to either the item or the group, and protects against the case where the association is not valid against either.

It also adds display of groups (including entity IDs, and properties) to the filereader UI.

image

(This shows a slightly different styling - th is text-align: left; instead of text-align: center; - happy to propose that as a follow-up change if desired).

For an example that shows the problem (and displays in the new UI), see https://github.com/nokiatech/heif_conformance/raw/master/conformance_files/C050.heic

bradh commented 1 year ago

Is there anything I can do to move this PR forward?

bradh commented 1 year ago

I've renamed vars and the tab label, and moved the entity group tab to be adjacent to item view tab.