search

gpac / mp4box.js

JavaScript version of GPAC's MP4Box tool
https://gpac.github.io/mp4box.js/
BSD 3-Clause "New" or "Revised" License
1.92k stars 325 forks source link

load the URL given on the search parameters #349

Closed DenizUgur closed 1 year ago

DenizUgur commented 1 year ago

Opened in place of #348

DenizUgur commented 1 year ago

@cconcolato Kindly bumping :)

DenizUgur commented 1 year ago

@cconcolato Kindly bumping this PR again 🙂

cconcolato commented 1 year ago

Can you explain what issue this is fixing?

DenizUgur commented 1 year ago

Loading a file from the query parameters is not working with the current state of the file reader demo. This is because there is no load function to call.

However, the correct function httpload with proper arguments completes the loading flow.

Example of an URL that doesn't work and with this fix it should be working again: https://gpac.github.io/mp4box.js/test/filereader.html?https://mpeggroup.github.io/FileFormatConformance/files/published/isobmff/21_segment.mp4

cconcolato commented 1 year ago

Oh, you mean, one has currently to hit the "Load" button and the change is removing the need for it?

DenizUgur commented 1 year ago

To be honest, I never thought about hitting Load because it felt like it didn't do anything at all. But yeah, this would load the file immediately.