search

gpambrozio / BlockAlertsAnd-ActionSheets

Beautifully done UIAlertView and UIActionSheet replacements inspired by TweetBot
http://codecropper.com/2012/01/replicating-tweetbots-alerts-and-action-sheets/
MIT License
1.41k stars 268 forks source link

iOS 8 orientation issue #77

Closed taymer closed 9 years ago

taymer commented 9 years ago

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

barrettj commented 9 years ago

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

taymer commented 9 years ago

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046 .

barrettj commented 9 years ago

In your history do you see the following commit:

1f989833 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99545586.

taymer commented 9 years ago

Yes on blockbackround.m (if i remember correctly) I wonder you can' t reproduce the issue. I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad

  1. Open the alert and rotate the device.

Thanks. Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha scritto:

In your history do you see the following commit:

1f989833 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046

.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99545586 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99546838 .

barrettj commented 9 years ago

Interesting. I definitely see this in the demo project, but not in my actual app that I use the alert in.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t reproduce the issue. I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad

  1. Open the alert and rotate the device.

Thanks. Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha scritto:

In your history do you see the following commit:

1f989833 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046

.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99545586 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99546838 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99552424.

barrettj commented 9 years ago

Try the commit I just pushed, it disables all custom rotation stuff on iOS 8 which should hopefully fix things.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t reproduce the issue. I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad

  1. Open the alert and rotate the device.

Thanks. Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha scritto:

In your history do you see the following commit:

1f989833 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046

.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99545586 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99546838 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99552424.

taymer commented 9 years ago

I' ll try tomorrow. I've no mac with me now (it' s evening in Italy ;-] ) Il 06/mag/2015 21:19, "Barrett Jacobsen" notifications@github.com ha scritto:

Try the commit I just pushed, it disables all custom rotation stuff on iOS 8 which should hopefully fix things.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t reproduce the issue. I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad

  1. Open the alert and rotate the device.

Thanks. Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha scritto:

In your history do you see the following commit:

1f989833 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually. Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub <

https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99533046

.

— Reply to this email directly or view it on GitHub <

https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99545586

.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99546838

.

— Reply to this email directly or view it on GitHub < https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99552424 .

— Reply to this email directly or view it on GitHub https://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/issues/77#issuecomment-99579043 .

taymer commented 9 years ago

It's OK. Thanks a lot.