search

gplessis / dotdeb-nginx

Dotdeb : Nginx
http://www.dotdeb.org/
BSD 2-Clause "Simplified" License
63 stars 31 forks source link

Directory /etc/nginx/modules-available is empty #85

Open b-a-t opened 8 years ago

b-a-t commented 8 years ago

First of all - thanks a lot for all your work, Guillaume!

Trying new 1.10.1 version of dotdeb-nginx I've noticed what I'd call inconsistency. After fresh installation the directory /etc/nginx/modules-available is entirely empty, while /etc/nginx/modules-enabled contanis reference to all the modules in the form of:

lrwxrwxrwx 1 root root 52 Jun 12 02:16 10-mod-http-ndk.conf -> /usr/share/nginx/modules-available/mod-http-ndk.conf
lrwxrwxrwx 1 root root 57 Jun 12 02:16 50-mod-http-auth-pam.conf -> /usr/share/nginx/modules-available/mod-http-auth-pam.conf
lrwxrwxrwx 1 root root 54 Jun 12 02:16 50-mod-http-geoip.conf -> /usr/share/nginx/modules-available/mod-http-geoip.conf
lrwxrwxrwx 1 root root 61 Jun 12 02:16 50-mod-http-image-filter.conf -> /usr/share/nginx/modules-available/mod-http-image-filter.conf
lrwxrwxrwx 1 root root 52 Jun 12 02:16 50-mod-http-lua.conf -> /usr/share/nginx/modules-available/mod-http-lua.conf
lrwxrwxrwx 1 root root 53 Jun 12 02:16 50-mod-http-perl.conf -> /usr/share/nginx/modules-available/mod-http-perl.conf
lrwxrwxrwx 1 root root 60 Jun 12 02:16 50-mod-http-xslt-filter.conf -> /usr/share/nginx/modules-available/mod-http-xslt-filter.conf
lrwxrwxrwx 1 root root 48 Jun 12 02:16 50-mod-mail.conf -> /usr/share/nginx/modules-available/mod-mail.conf
lrwxrwxrwx 1 root root 50 Jun 12 02:16 50-mod-stream.conf -> /usr/share/nginx/modules-available/mod-stream.conf

I understand the need to get all the modules in the modules-enabled to be able to start nginx after upgrade from the versions prior to 1.10.

Still, this setup is quite different to the way how sites-available -> sites-enabled works or how apache2 mods-available -> mods-enabled does. Also, direct links to /usr/share/nginx/modules-available/ seems violating the whole idea.

I'd suggest in this case make /etc/nginx/modules-available a symlink to /usr/share/nginx/modules-available/ and then make symlinks from modules-available to modules-enabled in a conventional way. Possibly, ngx-conf can be extended for this.