search

gpslab / geoip2

A Symfony Bundle for the Maxmind GeoIP2 API
https://www.maxmind.com/
MIT License
54 stars 12 forks source link

Making geoip2.reader service public #2

Closed jaimenj closed 6 years ago

jaimenj commented 6 years ago

This is necessary to make it work with Symfony 4. Because in Symfony 4 all services are private by default, so this service cannot be used by default.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 25.676% when pulling ac8cd16b1239ca894f406cf8eed9dfa71eed3e35 on jaimenj:making-service-public-by-default into b77414fa364c449ea9ee143ea56ae9ce04bdd0a3 on gpslab:master.

peter-gribanov commented 6 years ago

Good job :+1: I made a new release with your change.