search

gpslab / geoip2

A Symfony Bundle for the Maxmind GeoIP2 API
https://www.maxmind.com/
MIT License
54 stars 12 forks source link

New Symfony 4 bin/composer directory structure #9

Closed ChrisKinnan closed 5 years ago

ChrisKinnan commented 5 years ago

Hi thanks for this helpful bundle. The update script anticipates the need to use 'bin' rather than 'app' but the method useNewDirectoryStructure is looking for symfony-var-dir option. I added the symfony-bin-dir directory as an explicit option and the useNewDirectoryStructure method to look for that. I think this will help keep the script working with projects independent of 'symfony-var-dir' . Thanks!

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 25.899% when pulling 5dc008b10626330fd79dd51c679a29faa9ec25ad on ChrisKinnan:patch-1 into bb3cd973cb71dd7093c4c7029e3e948b899746b6 on gpslab:master.

peter-gribanov commented 5 years ago

Thanks for report

peter-gribanov commented 5 years ago

Thanks for the work you've done.