search

gpslab / geoip2

A Symfony Bundle for the Maxmind GeoIP2 API
https://www.maxmind.com/
MIT License
54 stars 12 forks source link

Do not download when licence is not set #91

Closed antedebaas closed 1 week ago

antedebaas commented 1 month ago

I needed the bundle not fail in the command because a license has not been set for my project there are use cases where a license will not be used (its up to the user) this pr will instead of blindly try a download show a warning when the license is not set and skip the download step.

peter-gribanov commented 1 week ago

Thanks for the PR :+1: Please fix the unit tests.

antedebaas commented 1 week ago

@peter-gribanov updated the tests and added a new test for a case without license

peter-gribanov commented 1 week ago

Good job :+1: Thank you.

peter-gribanov commented 1 week ago

@antedebaas your feature published in Release 2.1.2

antedebaas commented 1 week ago

thanks