gpstar81 / GPStar-proton-pack

GPStar Proton Pack and Neutrona Wand
https://www.gpstartechnologies.com
GNU General Public License v3.0
37 stars 8 forks source link

Unstable Brass Plated Proton Stream Animation #350

Open Aces6469 opened 1 month ago

Aces6469 commented 1 month ago

What would you like to add in terms of software changes?

Possibly update the FE lid off CTS animation to be more chaotic to simulate the brass plated proton pack's trifurcated proton stream. Could even be a toggle for the normal stream animations for those who would want to have a normal colored proton stream with the trifurcation (could be put in as a third option to the new barrel animation setting in the 6.0 EEPROM). Very unlikely to be added since it's super specific and probably a difficult thing to program, but I just thought I'd pitch the idea.

Would this request involve any specific hardware?

I doubt it, but it'd probably look best on the frutto barrel LEDs?

Homework Completed

nomakewan commented 1 month ago

It's actually already in planning for v6, because one of the major changes for v6 is rewriting a lot of the LED code to be able to write "sprites" to the LED arrays to improve how the animations look.

Likewise, one of the animations we would like to improve is the brass pack barrel animation. So yeah!

Aces6469 commented 1 month ago

Oh sweet! I presume it'd stay as a CTS only animation/coloring? Or would it move to the base barrel effect with the lid off?

nomakewan commented 1 month ago

That hasn't been decided just yet, but in my opinion all the "brass pack" stuff should be its own separate mode, and if that is the case, then the "normal" firing for it would indeed be the green shot with the orange lightning.

Aces6469 commented 1 month ago

As someone whose entire pack is the brass plated pack, I completely agree lol.

Aces6469 commented 1 month ago

as a quick side note though, it might be worth tuning the exact colors for the brass stream, the green doesn't come off as the more minty look, and the orange goes more yellow in my experience. Just some food for thought.

nomakewan commented 1 month ago

If you are basing your opinions on what it currently looks like, rest assured that the current animations are going in the bin and won't be referenced for v6.

We will of course take our respective copies of the bluray and try to get as close to the on-screen representation as the LED array will allow.