search

gpuweb / cts

WebGPU Conformance Test Suite
https://gpuweb.github.io/cts/
BSD 3-Clause "New" or "Revised" License
128 stars 80 forks source link

Test `texture-compression-bc-sliced-3d` #3761

Open mehmetoguzderin opened 4 months ago

mehmetoguzderin commented 4 months ago

https://github.com/gpuweb/gpuweb/issues/4705

webgpu:api,validation,texture,*, and also operation tests where applicable.

kainino0x commented 4 months ago

I think we also need to make sure we have basic sampling operation tests, as well as both validation and operation tests for copyTextureToTexture/TextureToBuffer/BufferToTexture and writeTexture.

mehmetoguzderin commented 4 months ago

@kainino0x Thank you very much for the guidance, I missed those aspects. I will follow-up with a PR for those tests, too! Appreciated!

kainino0x commented 4 months ago

@greggman since you just added 2d compressed texture sampling tests in #3760, would it make sense for you to do the sampling tests for 3d? It will probably fit into what you're already working on.

greggman commented 4 months ago

Yes, sure. I can either do it now and they'll fail or we can add them later but the code will just be almost copy and pasted from the 2d stuff so unless I remove them they'll already kind of maybe do the right thing but fail until implemented.

mehmetoguzderin commented 3 months ago

Change needs to cover not only validation but also operation, reopening. Thank you.

mehmetoguzderin commented 3 months ago

It seems like https://github.com/gpuweb/cts/commit/cb42984fa7f024120ce4731120007856e33f9d6a actually fixed the additional limitation in util/texture/base, and there doesn't seem to be any additional particular filters to not test copies or writes of compressed 3D formats. I'll create a draft PR to dry run. Thank you!

greggman commented 2 weeks ago

so fyi, the texture builtin tests should be able to test this stuff. Most of the exist tests just filter out compressed 3d (as slices) texture formats. If/when want to turn them on we just need to change the filters.

mehmetoguzderin commented 2 weeks ago

@greggman thank you very much for the information.