search

graalvm / container

GraalVM container images
Other
166 stars 37 forks source link

Set correct urls for {graalpy,truffleruby}-community #92

Closed eregon closed 4 months ago

eregon commented 5 months ago

The published images seem OK, I guess because GRAALVM_PKG was overridden on the command line when building them?

Another option could be to just use ARG GRAALVM_PKG without a default, but this seems clearer to explain where the archives come from.

BTW the Dockerfiles for graalvm-community seems confusing/messy too, because for instance: https://github.com/graalvm/container/blob/2a8e138fe0b0200a80a7addddedf186b5ff74192/graalvm-community/Dockerfile.ol9-java20#L26 but there is no JDK_BUILD nor JDK_BUILD_GRAALVM_ARCH_bin variables, so that default doesn't work.

Also there are still -java17/-java20 dockerfiles but the latest release is 21/22, so they seem outdated. I guess these dockerfiles could take the Java version as an ARG and not duplicate them per Java version. In general, it would be great if the Dockerfiles in this repo are up-to-date with the images that have been published, it seems not to be the case currently.

cc @fniephaus