search

graalvm / mandrel

Mandrel is a downstream distribution of the GraalVM community edition. Mandrel's main goal is to provide a native-image release specifically to support Quarkus.
Other
396 stars 15 forks source link

[24.1] Add reflection metadata for jfrTracing field. #762

Closed roberttoyonaga closed 4 months ago

roberttoyonaga commented 4 months ago

(cherry picked from commit e816ad6355cf8f4afa5fcf68177bda24456cebbf)

Related issue: https://github.com/graalvm/mandrel/issues/761

Even with this backport, I'm able to intermittently reproduce the failure here: https://github.com/Karm/mandrel-integration-tests/issues/268

I think there's more the the problem in https://github.com/Karm/mandrel-integration-tests/issues/268. I'll look into this more.

jerboaa commented 4 months ago

Even with this backport, I'm able to intermittently reproduce the failure here: Karm/mandrel-integration-tests#268

OK then, we should probably wait with backporting it until it's fully resolved. WDYT?

roberttoyonaga commented 4 months ago

Even with this backport, I'm able to intermittently reproduce the failure here: Karm/mandrel-integration-tests#268

OK then, we should probably wait with backporting it until it's fully resolved. WDYT?

Yes let’s do that

roberttoyonaga commented 4 months ago

I must have not set updated the GRAALVM_HOME environment variable on that test run that failed. After rebuilding everything and starting from scratch, I'm not able to reproduce the problem, even after repeated attempts. I think the patch works fine to resolve the issue.

Failing GHA:

zakkak commented 4 months ago

The CI failures are indeed known and unrelated, see https://github.com/graalvm/mandrel/actions/runs/9751570325

zakkak commented 4 months ago

Upstream backport PR https://github.com/oracle/graal/pull/9380

zakkak commented 3 months ago

This backport was dropped in favor of the upstream one https://github.com/oracle/graal/pull/9380 in c4639ba4170fa859e38aa08562debed8fe474d2f