Closed remkop closed 9 months ago
Thanks for the report. I'm quite amazed that gradle-build-action@v2.11
is working correctly with Gradle v1.12! I limit my testing to Gradle 3.x and higher.
Due to the magic of dynamic Groovy, I think simply changing:
void applyPluginExternally(PluginManager pluginManager, String pluginClassName)
to
void applyPluginExternally(def pluginManager, String pluginClassName)
might be enough to avoid failure on Gradle 1.12. The init script should then load correctly, and the code won't be executed unless you are explicitly enabling Gradle Enterprise injection (which I presume you're not).
@remkop I've pushed a simple attempt at a fix and it would be great if you could verify that it works.
You can test it out by running with gradle/gradle-build-action@prerelease/v2.11.1
. TIA.
@bigdaz That works, thank you!
The fix has been released in v2.11.1
. Thanks for the report.
Amazingly fast turnaround! Many thanks!
Summary
Error with gradle-build-action 2.11.0 and Gradle 1.12:
Description
My project picocli supports Java 5 and later. (GitHub Actions only supports Java 6+, so my CI pipeline tests Java 6+)
After upgrading
gradle-build-action
from 2.8.0 to 2.11.0, I experience the following error:Not sure why this is happening. Does this need to be a fully qualified class
org.gradle.api.plugins.PluginManager
? This class was introduced in Gradle 2.3, so I would not expect this error with Gradle 1.12...Attempted Workaround
I tried to configure as follows with property
gradle-enterprise.injection-enabled=false
but the error still occurs:Log Details
Some more context: