grafana / alloy

OpenTelemetry Collector distribution with programmable pipelines
https://grafana.com/oss/alloy
Apache License 2.0
1.28k stars 173 forks source link

Agent Flow Windows installer logging arguments #442

Open timo1707 opened 1 year ago

timo1707 commented 1 year ago

Request

Adding the possability to define a log path argument when Install the Grafana Agend on Windows. e.g. grafana-agent-flow-installer.exe /S /log="C:\Install\Logs\grafana-agent-flow-installer.log"

Use case

On larger Environments are usualy specific Logging paths e.g. "C:\Install\Logs\software01.log" required to monitor installation processes. e.g. on a new deployment several Software packages getting automaticly installed . to debug or control if all packages are installed, the relevant log path is getting analysed.

rfratto commented 1 year ago

Just to clarify, we're talking about the installer logs and not logs for the agent itself, right?

timo1707 commented 1 year ago

Just to clarify, we're talking about the installer logs and not logs for the agent itself, right?

exactly, the logs out of the installer Script

jkroepke commented 10 months ago

This seems to be possible with LogSet on inside the installer, however it required a non-default build of NSIS

Note that the NSIS_CONFIG_LOG build setting must be set (scons NSIS_CONFIG_LOG=yes) when building (it is not set by default) to support this.

Ref: https://nsis.sourceforge.io/Docs/Chapter4.html#installlog

Lucky, NSIS provides Windows binaries with on SourceForce (https://nsis.sourceforge.io/Special_Builds#Advanced_logging), with Logging support, but it needs to be guaranteed that the binary is available on the CI.