search

grafana / crossplane-provider-grafana

Crossplane provider of https://github.com/grafana/terraform-provider-grafana. Generated by https://github.com/upbound/upjet
Apache License 2.0
25 stars 13 forks source link

finish adding `ref` and `selector` fields for all Grafana OnCall resources #162

Closed joeyorlando closed 3 weeks ago

joeyorlando commented 4 weeks ago

Description of your changes

Adds all missing selector and ref fields for the following Grafana OnCall Crossplane resources:

Closes https://github.com/grafana/oncall/issues/4411

I have:

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@c5af3f9). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ====================================== Coverage ? 0.00% ====================================== Files ? 201 Lines ? 29392 Branches ? 0 ====================================== Hits ? 0 Misses ? 29392 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/grafana/crossplane-provider-grafana/pull/162/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/grafana/crossplane-provider-grafana/pull/162/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana) | `0.00% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grafana#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joeyorlando commented 4 weeks ago

@MasterExecuson see this PR.

One thing to note is that for any related object which is only represented by a Terraform datasource (as opposed to a resource), Crossplane doesn't allow us to specify refs/selectors for these. Terraform datasources are not translated to Crossplane resources unfortunately.

The workaround they have is this, basically using the Terraform provider for Crossplane to use the datasources directly.

Once we get v0.17.0 of this provider published, let me know if you're able to get this working with the linked documentation.