[Feature Request] Parsing response content of Non HTTP 200 response

beirtipol commented 3 weeks ago

The Spring boot /acuator/health endpoint will return a 503 error code if any of the components it is monitoring report a status of DOWN. The response body still contains valid JSON, but infinity doesn't attempt to parse it, it just says 'No data'.

This should still work, regardless of the response code.

Here's some sample JSON

{
    "status": "UP",
    "components": {
        "clientConfigServer": {
            "status": "UP",
            "details": {
                "propertySources": [
                    "configserver:git@github.mycompany.local:MyCompany/myapp-config.git/thisapp/thisapp-uat.yaml",
                    "configClient"
                ]
            }
        },
        "diskSpace": {
            "status": "UP",
            "details": {
                "total": 107317563392,
                "free": 24000552960,
                "threshold": 10485760,
                "path": "/application/.",
                "exists": true
            }
        },
        "someCustomCheck": {
            "status": "DOWN",
            "details": {
                "everything is": "awful"
            }
        },
        "livenessState": {
            "status": "UP"
        },
        "ping": {
            "status": "UP"
        },
        "readinessState": {
            "status": "UP"
        },
        "refreshScope": {
            "status": "UP"
        }
    },
    "groups": [
        "liveness",
        "readiness"
    ]
}

yesoreyeram commented 2 weeks ago

This is the expected behaviour of the plugin. How do you differentiate the 503 by the API error vs 503 of the underlying application health?

I would consider this as a feature request but not a bug.

yesoreyeram commented 2 weeks ago

actually this piece of code considers anything greater than HTTP 400 as error.

https://github.com/grafana/grafana-infinity-datasource/blob/6a6fa3a03615043ae4d0172fb01b20f3aa4809f2/pkg/infinity/client.go#L218-L220

We can accept something like ignoreHttpStatusCode: true in query then ignore http status codes in such cases

beirtipol commented 2 weeks ago

I guess I think of the plugin as something that is purely for fetching data rather than error codes. I appreciate it might not be a typical use case, but the data contained in the error response is what's useful.

Even with something like a 404, it is usually returned by a web server to indicate the page doesn't exist, but it is also totally valid to indicate that the resource you queried for doesn't exist, and the response might tell you more useful info.

In an ideal world, you would also be able to append the error code to the response object for something like colour coding the widget.

On Mon, 10 Jun 2024, 18:18 Sriram, @.***> wrote:

This is the expected behaviour of the plugin. How do you differentiate the 503 by the API error vs 503 of the underlying application health?

I would consider this as a feature request but not a bug.

— Reply to this email directly, view it on GitHub https://github.com/grafana/grafana-infinity-datasource/issues/874#issuecomment-2158906091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJQO3DYJQVGHF3NWY3KCKLZGXNVLAVCNFSM6AAAAABJCQNDEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYHEYDMMBZGE . You are receiving this because you authored the thread.Message ID: @.***>

grafana / grafana-infinity-datasource

[Feature Request] Parsing response content of Non HTTP 200 response #874