grafana / grafana-plugin-examples

181 stars 52 forks source link

Update plugin-e2e dep in ci #280

Closed sunker closed 5 months ago

sunker commented 5 months ago

Updates the plugin-e2e package so that we always run e2e tests using the latest minor/patch in CI.

sunker commented 5 months ago

it works, but probably we should think about solving this in examples themselves additionally.

How could we do that?

tolzhabayev commented 5 months ago

it works, but probably we should think about solving this in examples themselves additionally.

How could we do that?

dependabot could probably do that - open PRs with updates to this package. We can theoretically even auto merge those specific ones.

e.g. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request

if: contains(steps.metadata.outputs.dependency-names, '@grafana/plugin-e2e') && steps.metadata.outputs.update-type == 'version-update:semver-patch'
jackw commented 5 months ago

dependabot could probably do that - open PRs with updates to this package. We can theoretically even auto merge those specific ones.

I think this option gets my vote too. Whilst the changes in this PR work it gives us the idea that our e2e tests pass fine but when we run them locally or a developer copies the example as a starting point they'll fail which might cause confusion.

sunker commented 5 months ago

dependabot could probably do that - open PRs with updates to this package.

Yes this makes sense to me. I'll have a look at this

sunker commented 5 months ago

Closing this PR in favour of https://github.com/grafana/grafana-plugin-examples/pull/282. Please take a look when you have time @tolzhabayev @jackw.